fix: remove GetDisk operation in AttachDisk #678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andyzhangx The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
andyzhangx
force-pushed
the
reduce-getdisk
branch
from
ce3349f to
06fd74f
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/retest |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
fix: remove GetDisk operation in AttachDisk
This is actually one GetDisk operation in CSI driver AttachDisk interface, this PR removes GetDisk operation to reduce potential GetDisk throttling issue in large amount of disk attachment scenario.
And also retry immediately in DetachDisk is actually not necessary since CSI driver would retry if Detach failed in an outer looper, this could make things worse when there is throttling issue.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: